From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Wed, 27 Oct 2010 14:55:51 GMT
Subject: Re: [PATCH v3] Porcelain scripts: Rewrite cryptic "needs update" error message
Message-ID: <20101027145548.GA1136@kytes>
In-Reply-To: <1287499168-26569-1-git-send-email-artagnon@gmail.com>

Hi,

Ramkumar Ramachandra writes:
> Although Git interally has the facility to differentiate between
> porcelain and plubmbing commands and appropriately print errors,
> several shell scripts invoke plubming commands triggering cryptic
> plumbing errors to be displayed on a porcelain interface. This patch
> replaces the "needs update" message in git-pull and git-rebase, when
> `git update-index` is run, with a more friendly message.
> 
> Reported-by: Joshua Jensen <jjensen@workspacewhiz.com>
> Reported-by: Thore Husfeldt <thore.husfeldt@gmail.com>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
>  Ref: <1285877017-8060-1-git-send-email-artagnon@gmail.com> for v2.
>  Ref: <1285514516-5112-1-git-send-email-artagnon@gmail.com> for v1.
> 
>  Thanks to Matthieu for reviewing v1 and Junio for reviewing v2: I've
>  tried to attack the problem more conservatively in this patch. It
>  doesn't list paths, and doesn't print "generic" advice.

Junio: Is this patch alright?

-- Ram