From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 21 Oct 2010 16:53:40 GMT
Subject: Re: [PATCH] diff: report bogus input to -C/-M/-B
Message-ID: <20101021165340.GE3732@burratino>
In-Reply-To: <20101021144947.GA18210@sigill.intra.peff.net>

Jeff King wrote:

> Before:
> 
>   $ git diff -CM
>   $ echo $?
>   128
> 
> After:
> 
>   $ git diff -CM
>   error: invalid argument to -C: M
>   $ echo $?
>   128

Yes, please.

Who is it that exits(128) in this code path?  Are there other
functions it calls that might return an error without reporting it to
stderr?