From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 20 Oct 2010 01:18:20 GMT
Subject: Re: [PATCH 2/3] builtins: utilize startup_info->help where possible
Message-ID: <20101020011820.GA6872@burratino>
In-Reply-To: <AANLkTinvSKAyXkzjUgxvrDWvuHWpa+46XVxTu=tWck53@mail.gmail.com>

Nguyen Thai Ngoc Duy wrote:

> That. And simpler check. I mean "if (startup_info->help)" takes a tiny
> bit less energy for me to understand than "if (argc == 2 && argv[1] ==
> "-h")". It's also good for grepping.

Mm, that still does not motivate the churn to me.  But "we can change
the meaning to 'if (argc >= 2 && !strcmp(argv[1], "-h"))' some day"
motivates it okay, I think.

> 2010/10/20 Jonathan Nieder <jrnieder@gmail.com>:

>> Maybe (modulo names) it would be better to do
[...]
> Can it be relaxed later when someone comes up with "--help-all" or something?

Yes, I was just thinking out loud.  By "relaxed" I meant the above
(changing == to >= in one place).  Now that I've thought it over,
I don't mind startup_info->help so much.

Hope that helps, and sorry for the noise.
Jonathan