From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 18 Oct 2010 17:03:31 GMT
Subject: Re: [PATCH/RFC 0/11] Building up the delta parser
Message-ID: <20101018170331.GB6718@burratino>
In-Reply-To: <20101018170018.GJ22376@kytes>

Ramkumar Ramachandra wrote:
> Jonathan Nieder writes:
>> Jonathan Nieder wrote:

>>> Implement an svndiff 0 interpreter
[...]
> Eager to see this go through to `master`.

I think the strbuf use breaks the contrib/svn-fe/svn-fe build
somewhere.  Probably something like the following is needed.

(moving the -I flags off of the compilation command line is
justa "while at it" thing, for consistency with the toplevel
Makefile)

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
diff --git a/contrib/svn-fe/Makefile b/contrib/svn-fe/Makefile
index 360d8da..9e8f174 100644
--- a/contrib/svn-fe/Makefile
+++ b/contrib/svn-fe/Makefile
@@ -6,7 +6,7 @@ MV = mv
 
 CFLAGS = -g -O2 -Wall
 LDFLAGS =
-ALL_CFLAGS = $(CFLAGS)
+ALL_CFLAGS = $(CFLAGS) -I../../vcs-svn -I../..
 ALL_LDFLAGS = $(LDFLAGS)
 EXTLIBS =
 
@@ -38,7 +38,7 @@ svn-fe$X: svn-fe.o $(VCSSVN_LIB) $(GIT_LIB)
 		$(ALL_LDFLAGS) $(LIBS)
 
 svn-fe.o: svn-fe.c ../../vcs-svn/svndump.h
-	$(QUIET_CC)$(CC) -I../../vcs-svn -o $*.o -c $(ALL_CFLAGS) $<
+	$(QUIET_CC)$(CC) -o $*.o -c $(ALL_CFLAGS) $<
 
 svn-fe.html: svn-fe.txt
 	$(QUIET_SUBDIR0)../../Documentation $(QUIET_SUBDIR1) \