From: Jonathan Nieder <jrnieder@gmail.com>
Date: Fri, 15 Oct 2010 05:34:14 GMT
Subject: Re: [PATCH 1/2] test-lib: allow test code to check the list of declared prerequisites
Message-ID: <20101015053414.GC21830@burratino>
In-Reply-To: <AANLkTikkWw4Ju4jJFtvKX+s2LMkveQX-uBQyS41A=Vh2@mail.gmail.com>

Ævar Arnfjörð Bjarmason wrote:
> On Thu, Oct 14, 2010 at 20:40, Jonathan Nieder <jrnieder@gmail.com> wrote:

>> +       case ",$test_prereq," in
>> +       *,$1,*)
>
> Won't this only work with:
> 
>     test_expect_success FOO,THINGYOUWANT,BAR '...'
> 
> And not:
> 
>     test_expect_success THINGYOUWANT,FOO,BAR '...'
> 
> ?

	$ case ,X,FOO,BAR, in
	  *,X,*)
		echo ok
		;;
	  *)
		echo not ok
		;;
	  esac
	ok
	$

Looks safe to me.  A * can match any string, including the empty string[1].

[1] http://www.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_13_02