From: Jeff King <peff@peff.net>
Date: Fri, 15 Oct 2010 04:42:53 GMT
Subject: Re: [PATCH/RFC 0/2] test_terminal: check that TTY prerequisite is declared
Message-ID: <20101015044252.GA22438@sigill.intra.peff.net>
In-Reply-To: <20101014203721.GA28958@burratino>

On Thu, Oct 14, 2010 at 03:37:21PM -0500, Jonathan Nieder wrote:

> > Oops, good catch. I think we should already catch it, as test_terminal
> > will not be defined at all in the no-tty case. We could print a nicer
> > message, but
> 
> I rather meant something like this.
> 
> Patch 1 exposes the internal $prereq variable from
> test_expect_(success|failure).  Maybe it should be called
> GIT_TEST_something to avoid trampling other programs' namespaces?  Not
> sure.
> 
> Patch 2 introduces some magic autodetection so people that never run
> tests without -v can still notice the missing TTY prereqs.

Yeah, that is better, as it will catch the lack of prerequisite even on
systems where the prerequisite is met.

It seems like a lot of code to catch something small, but on the other
hand, it does seem to be a repeated mistake.

-Peff