From: Jeff King <peff@peff.net>
Date: Thu, 14 Oct 2010 03:02:20 GMT
Subject: [PATCH 0/3] more push progress tests
Message-ID: <20101014030220.GB20685@sigill.intra.peff.net>
In-Reply-To: <1286998311-5112-1-git-send-email-rctay89@gmail.com>

On Thu, Oct 14, 2010 at 03:31:48AM +0800, Tay Ray Chuan wrote:

> [PATCH 1/3] t5523-push-upstream: add function to ensure fresh upstream repo
> [PATCH 2/3] t5523-push-upstream: test progress messages
> [PATCH 3/3] push: pass --progress down to git-pack-objects

I had hoped to have a fix for --no-progress, but munging the tests took
so long that now I am sleepy. :) So here are some extra tests on top of
your series. The first two are refactoring, and the third has the new
tests. It checks regular stderr-is-tty progress and that "push -q"
suppresses progress, as Junio asked elsewhere. And it reveals the bug in
--no-progress.

It might make more sense to actually re-roll your series with the
refactoring at the front, and my 3/3 squashed into your 2/3.

Also, these tests feel a bit out of place in t5523, but I don't see a
better place for them to go. Perhaps they should go in their own test
script. I don't feel strongly, though.

  [1/3]: tests: factor out terminal handling from t7006
  [2/3]: tests: test terminal output to both stdout and stderr
  [3/3]: t5523: test push progress output to tty

-Peff