From: Jonathan Nieder Date: Tue, 12 Oct 2010 18:48:56 GMT Subject: Re: [PATCH 1/7] Teach fast-import to print the id of each imported commit Message-ID: <20101012184856.GA16103@burratino> In-Reply-To: Sverre Rabbelier wrote: > On Tue, Oct 12, 2010 at 15:50, David Barr wrote: >> +       } else if (!prefixcmp(feature, "report-fd=")) { >> +               option_report_fd(feature + strlen("report-fd=")); > > Note that adding it here means that we _do_ support in-stream > 'report-fd' specification, which is fine by me since it's overridable > on the commandline, but there was some discussion earlier that we > _shouldn't_ support this. Reference: http://thread.gmane.org/gmane.comp.version-control.git/156280 Thanks for the reminder. I still think Sam is right fwiw.