From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 11 Oct 2010 22:07:42 GMT
Subject: Re: [PATCH v4 01/15] mingw: add network-wrappers for daemon
Message-ID: <20101011220742.GA6277@burratino>
In-Reply-To: <1286833829-5116-2-git-send-email-kusmabite@gmail.com>

Erik Faye-Lund wrote:

> From: Mike Pape <dotzenlabs@gmail.com>
> 
> git-daemon requires some socket-functionality that is not yet
> supported in the Windows-port. This patch adds said functionality,
> and makes sure WSAStartup gets called by socket(), since it is the
> first network-call in git-daemon.

For the curious: gethostbyname(), getaddrinfo(), and getnameinfo()
already call WSAStartup if it hasn't already been called.  So
imap-send and the libgit transport code do not suffer from the same
problem.  Similarly for git daemon in the !NO_IPV6 case.

In the NO_IPV6 case, git daemon does not call getaddrinfo() and
--listen=<hostname> does not work (why?), so we have to hook into
socket(), too.

Looks good to my winsock-ignorant eyes.