From: Johannes Sixt <j6t@kdbg.org>
Date: Sun, 10 Oct 2010 20:51:26 GMT
Subject: Re: [msysGit] [PATCH v3 02/14] mingw: implement syslog
Message-ID: <201010102251.27095.j6t@kdbg.org>
In-Reply-To: <AANLkTinsqAOj7LtACpbcOrVZfeUApDjmQe2uYLH8npBF@mail.gmail.com>

On Sonntag, 10. Oktober 2010, Erik Faye-Lund wrote:
> On Sun, Oct 10, 2010 at 9:50 PM, Eric Sunshine <ericsunshine@gmail.com> 
wrote:
> > On 10/10/2010 9:20 AM, Erik Faye-Lund wrote:
> >> +       /*
> >> +        * ReportEvent() doesn't handle strings containing %n, where n
> >> is +        * an integer. Such events must be reformatted by the caller.
> >> +        */
> >
> > The comment about '%n' seems to be warning about a potential problem but
> > does not actually protect against it. Should this issue be handled?
>
> This is again an issue that was discussed in the first round.
> ReportEvent() CANNOT report a string containing "%n" (where n is an
> integer). And while we could probably try to work around it by
> inserting a space or something, and I don't think we ever were able to
> find a case where we could report a string containing "%n" in the
> first place...

I recall that it was mentioned that this could happen for IPv6 addresses?

-- Hannes