From: Jeff King <peff@peff.net>
Date: Tue, 05 Oct 2010 18:02:14 GMT
Subject: Re: [BUG] git-svn parses --pretty=medium log output, fails when log.decorate is true
Message-ID: <20101005180214.GA12861@sigill.intra.peff.net>
In-Reply-To: <4CAB6620.4000909@debugon.org>

On Tue, Oct 05, 2010 at 07:53:36PM +0200, Mathias Lafeldt wrote:

> > --- a/git-svn.perl
> > +++ b/git-svn.perl
> > @@ -1514,7 +1514,7 @@ sub cmt_sha2rev_batch {
> >  
> >  sub working_head_info {
> >  	my ($head, $refs) = @_;
> > -	my @args = ('log', '--no-color', '--first-parent', '--pretty=medium');
> > +	my @args = ('rev-list', '--first-parent', '--pretty=medium');
> >  	my ($fh, $ctx) = command_output_pipe(@args, $head);
> >  	my $hash;
> >  	my %max;
> 
> You're right. Using rev-list looks like a much cleaner solution.
> 
> In addition, I think we can replace the call to git-log in git_svn_log_cmd() too.

I don't think so. It uses diff options like "--raw --name-status" which
rev-list does not support. I think it is not buggy, though, as it uses
--format=raw.

-Peff