From: Jonathan Nieder Date: Mon, 04 Oct 2010 11:38:38 GMT Subject: Re: [PATCHv6 16/16] Introduce portable_unset and use it to ensure proper && chaining Message-ID: <20101004113838.GF4738@burratino> In-Reply-To: <7vy6ae8kdi.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > Hmm, the pros and cons between allowing test_might_fail on normal commands > vs introducing cmd_might_fail are questionable, though. I cannot think of > a case where we would want to tolerate death by signal or segv on non git > commands Okay, makes sense. I would be happier if exit statuses 129 and 129-256 were disallowed by test_must_fail, too, but that does not make it any less useful for cases like "test_might_fail grep needle haystack >result". And it is better to avoid introducing yet another command to learn.