From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 04 Oct 2010 09:28:30 GMT
Subject: Re: [PATCHv6 01/16] test-lib: make test_expect_code a test command
Message-ID: <20101004092830.GM24884@burratino>
In-Reply-To: <AANLkTink3gPGVGXnO2j1cvfHShPG1Lq23eeY6m+7b1bK@mail.gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> On the other hand I just tested git in a path called /tmp/\\"\\/git/t

I tried /tmp/test"git and tests other than t0000.5 seem to work fine.

> and found that every single one of our tests fail.

Every test script, not every test, right?

That's a makefile bug, I think: the bin-wrappers/% rule does not
sed-quote the working directory before passing it to sed.  After
working around that with GIT_TEST_OPTS=--with-dashes, tests are
running without trouble.

I don't think these edge cases are particularly important, but I
do think it's better to make sure code that takes care of the edge
cases when it's easy.