From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 03 Oct 2010 14:32:11 GMT
Subject: Re: [PATCHv5 08/16] t4019 (diff-wserror): add lots of missing &&
Message-ID: <20101003143211.GD17084@burratino>
In-Reply-To: <1286082644-31595-9-git-send-email-newren@gmail.com>

Elijah Newren wrote:

> --- a/t/t4019-diff-wserror.sh
> +++ b/t/t4019-diff-wserror.sh
> @@ -40,7 +40,7 @@ prepare_output () {
>  
>  test_expect_success default '
>  
> -	prepare_output
> +	prepare_output &&

As I asked before:

The exit status from prepare_output is the exit status from its last
command, which is "grep -v <something blue>".  It seems that never
fails in these test cases, but should we be relying on that?

So I would be more comfortable with the following on top.

---
diff --git a/t/t4019-diff-wserror.sh b/t/t4019-diff-wserror.sh
index 36f06c7..afd74c8 100755
--- a/t/t4019-diff-wserror.sh
+++ b/t/t4019-diff-wserror.sh
@@ -36,6 +36,7 @@ prepare_output () {
 	git diff --color >output
 	$grep_a "$blue_grep" output >error
 	$grep_a -v "$blue_grep" output >normal
+	return 0
 }

 test_expect_success default '