From: Jakub Narebski <jnareb@gmail.com>
Date: Sun, 26 Sep 2010 22:34:28 GMT
Subject: Re: [PATCHv5 10/12] gitweb: git_repo_url() routine
Message-ID: <201009270034.29603.jnareb@gmail.com>
In-Reply-To: <1285344167-8518-11-git-send-email-giuseppe.bilotta@gmail.com>

On Fri, 24 Sep 2010, Giuseppe Bilotta wrote:

> The routine creates a table row with a name and a repository address,
> like the one used at the top of summary view.
[...]

> +sub git_repo_url {
> +	my ($name, $url) = @_;
> +	return "<tr class=\"metadata_url\"><td>$name</td><td>$url</td></tr>\n";
> +}

It should be  *format_repo_url*, and not git_repo_url, isn't it?

By the way, doesn't gitweb include code dealing with repository URL;
why you don't _use_ this subroutine, then?

-- 
Jakub Narebski
Poland