From: Jonathan Nieder <jrnieder@gmail.com>
Date: Fri, 24 Sep 2010 19:43:13 GMT
Subject: Re: [RFC/PATCH 0/3] fast-import: give importers access to the object store
Message-ID: <20100924194313.GA8114@burratino>
In-Reply-To: <1284596048.3298.3.camel@wilber>

Hi Sam,

Sam Vilain wrote:
> On Sat, 2010-09-04 at 22:15 -0500, Jonathan Nieder wrote:

>> It works like this:
>> 
>> frontend:
>> 	feature report-fd=3
>> 	commit refs/heads/master
>> 	... revision 1 ...
>> 
>> importer:
>> 	abc7856cba76bca87a65bca76bca8bca98bca78bca76
>
> This is probably quite a late comment, but I don't think that
> 'report-fd=3' is a good idea in a protocol like this.

Yes, I guess "feature report-fd=3" is a protocol layering violation.
Unfortunately import-marks and export-marks have already set a
precedent.

How about a "feature report-fd" (with no argument) that checks if the
report-fd was set and errors out if not?

Well-behaved streams could use that and rely on the fd to be set on
the command line, while poorly-behaved streams could still use
"feature report-fd=whatever" to get the effect of --report-fd=whatever
and avoid breaking UI consistency.