From: Jakub Narebski Date: Tue, 21 Sep 2010 19:09:40 GMT Subject: Re: [PATCH] Enable highlight executable path as a configuration option Message-ID: <201009212109.41676.jnareb@gmail.com> In-Reply-To: <4C985DDF.8060807@cdwilson.us> On Tue, 21 Sep 2010, Christopher Wilson wrote: > Jakub, thanks for the helpful feedback. I included the updated patch > (see below) which includes the changes you suggested. > -- >8 -- > Subject: [PATCH] Enable highlight executable path as a configuration option > > Allow build-time/run-time configuration of the highlight executable > (must be the one from http://www.andre-simon.de due to assumptions > about parameters and output). Defaults to previous behavior which > assumes that highlight is available on the server PATH. However, if > this is not the case, the path to the highlight executable can be > configured at build time as a configuration variable > > HIGHLIGHT_BIN = /path/to/highlight > > or at runtime by configuring GITWEB_CONFIG > > $highlight_bin = /path/to/highlight > > Signed-off-by: Christopher Wilson For what it is worth it: Acked-by: Jakub Narebski It would certainly be nice to have tests for $highlight_bin, but even assuming that HIGHLIGHT prerequisite is met, I don't know how such test could be written. It is not a show-stopper. -- Jakub Narebski Poland