From: Johannes Sixt <j6t@kdbg.org>
Date: Wed, 08 Sep 2010 18:47:49 GMT
Subject: Re: [PATCH] fast-export: ensure that a renamed file is printed after all references
Message-ID: <201009082047.50083.j6t@kdbg.org>
In-Reply-To: <AANLkTim4iuDOG9U1epcafWarckaa6ZnxCOpfJW8KJW_m@mail.gmail.com>

On Mittwoch, 8. September 2010, Elijah Newren wrote:
> Patch and description looks good to me...however, I was a little
> surprised to see no testsuite addition or additional explanation.  Are
> you seeing some t9350 tests fail on some platform despite passing on
> linux?

Yes, I see the problem in t9350 on Windows. It is impossible to write a test 
for it because the test would depend on the unspecified behavior of qsort.

BTW, I don't know whether the diff machinery guarantees to produce 'C' and 'R' 
records in this order. If there is no such guarantee, then fast-export would 
have been broken even before 060df62.

-- Hannes