From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Sun, 05 Sep 2010 08:47:35 GMT
Subject: Re: [RFC/PATCH 0/3] fast-import: give importers access to the object store
Message-ID: <20100905084731.GB15511@kytes>
In-Reply-To: <AANLkTimqMJ1vHaJL65RZ4PuxONtg1evn4vBdPks_odqq@mail.gmail.com>

Hi Sverre,

Sverre Rabbelier writes:
> On Sun, Sep 5, 2010 at 01:08, Ramkumar Ramachandra <artagnon@gmail.com> wrote:
> >> Another possible concern is that this is very much git specific.
> >> Other fast-import backends are just not going to be able to do
> >> it with the same format.  Is there a convention for naming
> >> options like that?
> >
> > Why is this a concern? We aren't even breaking backward
> > compatibility. This bidi interface should only be used by SVN-like
> > frontends.
> 
> I don't agree, imagine implementing hg-remote-svn (or the conceptual
> equivalent at least), it would require the same functionality, yes?
> You need to retrieve something from fast-import that you previously
> gave it.

Ah, yes. I didn't think of that. If fast-import is already mature,
it's probably a good idea to design a new protocol altogether based on
this and not call it fast-import?

> > We'll get ideas to improve this as svn-fe gets built up. On a related
> > note, we should probably extend the git-remote-testgit helper to use
> > this feature in future to facilitate writing unittests.
> 
> Hmmm, that would be somewhat difficult I suspect, the reason
> git-remote-testgit was so easy to write is because git-fast-export and
> git-fast-import do exactly what I wanted to test. You'd have to teach
> munge the fast-export stream even more to insert this feature somehow,
> I suspect that'll be a non-trivial feat. Of course, you will need to
> test it somehow, I suspect that Jonathan's current approach (using
> hardcoded streams) might be the easiest.

Hm, ok. Whatever makes testing easier.

-- Ram