From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 31 Aug 2010 15:03:01 GMT
Subject: Re: [PATCH/RFC 05/17] gettext: make the simple parts of git-init localizable
Message-ID: <20100831150301.GE2315@burratino>
In-Reply-To: <1283203703-26923-6-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> --- a/builtin/init-db.c
> +++ b/builtin/init-db.c
> @@ -31,7 +31,7 @@ static void safe_create_dir(const char *dir, int share)
>  		}
>  	}
>  	else if (share && adjust_shared_perm(dir))
> -		die("Could not make %s writable by group", dir);
> +		die(_("Could not make %s writable by group"), dir);

Sensible.

I wonder if die() should not just be taught to automatically look up
translations for its format string (could gettext handle that?).

Although we try not to change plumbing error messages without good
reason, details of error messages change often enough that imvho
scripts should not be relying on them.

> -				die_errno("cannot stat '%s'", path);
> +				die_errno(_("cannot stat '%s'"), path);

Will strerror() cope correctly without LC_CTYPE set up?  (Not part
of this series, just something I was reminded of.)