From: Jonathan Nieder Date: Tue, 31 Aug 2010 14:32:36 GMT Subject: Re: [PATCH 1/2] merge: Make '--log' an integer option for number of shortlog entries Message-ID: <20100831143236.GC2315@burratino> In-Reply-To: <1283226800-28980-1-git-send-email-artagnon@gmail.com> Ramkumar Ramachandra wrote: > Change the command-line '--log' option from a boolean option to an > integer option What does "git merge --log=-1" do? It looks like you have made "git fmt-merge-msg --log=-1" equivalent to --log=20, but it might be better to error out or use INT_MAX or something (especially because of plans to make -1 mean "infinity" later). Thanks for your perseverance. Aside from those two nits, the patch looks good.