From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 30 Aug 2010 02:12:05 GMT
Subject: Re: [PATCH 01/13] fast-import: add the 'done' command
Message-ID: <20100830021205.GJ2305@burratino>
In-Reply-To: <AANLkTimNsVeGLB5=y8WyLqdkiQFwoBkdp_YrfuuT_5Ec@mail.gmail.com>

[out of order for convenience]
Sverre Rabbelier wrote:

> Does it matter much which way the importer is called? If it ends early
> at a valid point nobody will know regardless of how it is called, no?

If the importer calls fast-import itself, it can

 1. close the pipe to fast-import
 2. wait for fast-import to exit
 3. print a relevant message
 4. exit

> I think it makes sense to say that if you issue a 'feature done', we
> change the code that checks for EOF to error instead of quit.

Ok. :)