From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Wed, 25 Aug 2010 08:44:21 GMT
Subject: Re: [PATCH 0/2] log/ format-patch improvements
Message-ID: <20100825084416.GC3280@kytes>
In-Reply-To: <1282422531-29673-1-git-send-email-artagnon@gmail.com>

Hi,

Ramkumar Ramachandra writes:
> The first patch implements Jakub's suggestion. Arguably, it's slightly
> complicated- it took me more than a few minutes to do the math with
> `nr` and `nr_i`.
> 
> The second patch clarifies the meaning of the `-<n>` option. We should
> also probably force the mutual exclusivity of `-<n>` and <revision
> range> to avoid confusion.
> 
> Additionally, thanks to Thomas for drilling into me the fundamental
> difference between -<n> and a revision range (on IRC).
> 
> Ramkumar Ramachandra (2):
>   git-format-patch: Print a diagnostic message when ignoring commits
>   log: Improve description of '-<n>' option in documentation
> 
>  Documentation/git-format-patch.txt |    2 +-
>  Documentation/git-log.txt          |    2 +-
>  builtin/log.c                      |   42 ++++++++++++++++++++++++++---------
>  3 files changed, 33 insertions(+), 13 deletions(-)

Do you see value in this patch or is it just unnecessary baggage?

-- Ram