From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 24 Aug 2010 23:15:36 GMT
Subject: Re: [PATCH 03/32] cache-tree: ignore CE_REMOVE entries in verify_cache()
Message-ID: <20100824231536.GE2376@burratino>
In-Reply-To: <1282688422-7738-4-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy wrote:

> --- a/cache-tree.c
> +++ b/cache-tree.c
> @@ -156,6 +156,8 @@ static int verify_cache(struct cache_entry **cache,
>  	funny = 0;
>  	for (i = 0; i < entries; i++) {
>  		struct cache_entry *ce = cache[i];
> +		if (ce->ce_flags & CE_REMOVE)
> +			continue;
>  		if (ce_stage(ce) || (ce->ce_flags & CE_INTENT_TO_ADD)) {
>  			if (10 < ++funny) {
>  				fprintf(stderr, "...\n");

In other words, this teaches internal write-tree callers to ignore
unmerged and intent-to-add entries marked with CE_REMOVE.

Why?  When does this come up?