From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 24 Aug 2010 05:28:46 GMT
Subject: Re: [PATCH v2 1/3] clone: warn users --depth is ignored in local clones
Message-ID: <20100824052846.GE20037@burratino>
In-Reply-To: <1282565304-3122-1-git-send-email-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy wrote:

> +++ b/builtin/clone.c
> @@ -361,7 +361,7 @@ static void write_remote_refs(const struct ref *local_refs)
>  
>  int cmd_clone(int argc, const char **argv, const char *prefix)
>  {
> -	int is_bundle = 0;
> +	int is_bundle = 0, is_local;
>  	struct stat buf;
>  	const char *repo_name, *repo, *work_tree, *git_dir;
>  	char *path, *dir;
> @@ -414,6 +414,9 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
>  		repo = xstrdup(make_absolute_path(repo_name));
>  	else
>  		repo = repo_name;
> +	is_local = path && !is_bundle;
> +	if (is_local && option_depth)
> +		warning("--depth is ignored in local clones, use file:// instead.");

Micronit: this comma should be a semicolon or period.

As for the patch itself: I like it.  I could have used this advice
about a year ago.