From: David Aguilar <davvid@gmail.com>
Date: Wed, 18 Aug 2010 15:46:49 GMT
Subject: Re: [PATCH] submodule sync: Update "submodule.<name>.url"
Message-ID: <20100818154637.GA10028@gmail.com>
In-Reply-To: <4C6BB9E2.4060700@viscovery.net>

On Wed, Aug 18, 2010 at 12:45:54PM +0200, Johannes Sixt wrote:
> Am 8/18/2010 12:01, schrieb David Aguilar:
> > @@ -840,9 +840,10 @@ cmd_sync()
> >  		then
> >  		(
> >  			clear_local_git_env
> > +			say "Synchronizing submodule url for '$name'"
> > +			git config submodule."$name".url "$url"
> 
> This git config applies to the super module, right? As such, shouldn't it
> happen before you clear_local_git_env?


Good catch, thanks.  I'll resend.


> 
> >  			cd "$path"
> >  			remote=$(get_default_remote)
> > -			say "Synchronizing submodule url for '$name'"
> >  			git config remote."$remote".url "$url"
> >  		)
> 
> -- Hannes

-- 

	David