From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 18 Aug 2010 04:21:07 GMT
Subject: Re: [PATCH] git-gui: change the termination checks to avoid potential hang.
Message-ID: <20100818042107.GC21185@burratino>
In-Reply-To: <87iq3bh1op.fsf_-_@fox.patthoyts.tk>

Pat Thoyts wrote:

> Supposedly

And consistently.

 $ wish
 % puts $tcl_version
 8.5
 % puts $tk_version
 8.5
 $ dpkg -l tcl8.5 tk8.5 | tail -2
 ii  tcl8.5         8.5.8-2       Tcl (the Tool Command Language) v8.5 - ru
 ii  tk8.5          8.5.8-1       Tk toolkit for Tcl and X11, v8.5 - run-ti
 $ ./git-gui--askpass
 <types passphrase>

The window would stay open and hang.

> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
> ---
>  git-gui--askpass |   17 +++++++++++------
>  1 files changed, 11 insertions(+), 6 deletions(-)

Tested-by: Jonathan Nieder <jrnieder@gmail.com>

> +++ b/git-gui--askpass
[...]
> +vwait rc
> +exit $rc

I like it.

Thanks for keeping git gui in good shape.