From: Jonathan Nieder Date: Thu, 12 Aug 2010 21:30:47 GMT Subject: Re: [PATCH 05/10] Add string-specific memory pool Message-ID: <20100812213047.GH2029@burratino> In-Reply-To: <7vmxsru4ny.fsf@alter.siamese.dyndns.org> Junio C Hamano wrote: > Jonathan Nieder writes: >> diff --git a/Makefile b/Makefile >> index e7c33ec..24103c9 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -415,6 +415,7 @@ TEST_PROGRAMS_NEED_X += test-path-utils >> TEST_PROGRAMS_NEED_X += test-run-command >> TEST_PROGRAMS_NEED_X += test-sha1 >> TEST_PROGRAMS_NEED_X += test-sigchain >> +TEST_PROGRAMS_NEED_X += test-string-pool >> TEST_PROGRAMS_NEED_X += test-treap >> TEST_PROGRAMS_NEED_X += test-index-version > > Does your Makefile do the right thing to vcs-svn/*.[oa] upon "make clean"? Good catch. Here’s a fixup for patch 2 (“Introduce vcs-svn lib”). -- 8< -- Subject: vcs-svn: remove build artifacts on “make clean” Signed-off-by: Jonathan Nieder --- diff --git a/Makefile b/Makefile index 2418820..24c4b3d 100644 --- a/Makefile +++ b/Makefile @@ -2184,8 +2184,8 @@ distclean: clean $(RM) configure clean: - $(RM) *.o block-sha1/*.o ppc/*.o compat/*.o compat/*/*.o xdiff/*.o \ - builtin/*.o $(LIB_FILE) $(XDIFF_LIB) + $(RM) *.o block-sha1/*.o ppc/*.o compat/*.o compat/*/*.o xdiff/*.o vcs-svn/*.o \ + builtin/*.o $(LIB_FILE) $(XDIFF_LIB) $(VCSSVN_LIB) $(RM) $(ALL_PROGRAMS) $(SCRIPT_LIB) $(BUILT_INS) git$X $(RM) $(TEST_PROGRAMS) $(RM) -r bin-wrappers --