From: Thomas Rast <trast@student.ethz.ch>
Date: Wed, 11 Aug 2010 07:11:39 GMT
Subject: Re: [PATCH 9/9] commit: suppress status summary when no changes staged
Message-ID: <201008110911.40133.trast@student.ethz.ch>
In-Reply-To: <20100725010230.GI18420@burratino>

Jonathan Nieder wrote:
> Example: before:
>
> 	$ git commit
> 	# On branch master
> 	# Changed but not updated:
[...]
> 	no changes added to commit (use "git add" and/or "git commit -a")
> 	$
>
> After:
>
> 	$ git commit
> 	no changes added to commit (use "git add" and/or "git commit -a")
> 	$

Either Junio just picked this up in the last push or I just never
noticed before, but this breaks t6040 which tests for the "On branch
..." stuff:

  ../trash directory.t6040-tracking-info$ git commit --dry-run
  # On branch follower
  # Your branch is ahead of 'master' by 1 commit.
  #
  nothing to commit (use -u to show untracked files)
  ../trash directory.t6040-tracking-info$ ~/g/git-commit --dry-run
  nothing to commit (use -u to show untracked files)

resulting in

  expecting success:
          (
                  cd test &&
                  git checkout b1 >/dev/null &&
                  # reports nothing to commit
                  test_must_fail git commit --dry-run
          ) >actual &&
          grep "have 1 and 1 different" actual

  Already on 'b1'
  not ok - 5 status

--
Thomas Rast
trast@{inf,student}.ethz.ch