From: Jonathan Nieder Date: Tue, 10 Aug 2010 03:28:07 GMT Subject: [PATCH/RFC 1/3] core: Stop leaking ondisk_cache_entrys Message-ID: <20100810032807.GB2386@burratino> In-Reply-To: <20100810032647.GA2386@burratino> Noticed with valgrind. Signed-off-by: Jonathan Nieder --- read-cache.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/read-cache.c b/read-cache.c index f1f789b..1f42473 100644 --- a/read-cache.c +++ b/read-cache.c @@ -1516,6 +1516,7 @@ static int ce_write_entry(git_SHA_CTX *c, int fd, struct cache_entry *ce) int size = ondisk_ce_size(ce); struct ondisk_cache_entry *ondisk = xcalloc(1, size); char *name; + int result; ondisk->ctime.sec = htonl(ce->ce_ctime.sec); ondisk->mtime.sec = htonl(ce->ce_mtime.sec); @@ -1539,7 +1540,9 @@ static int ce_write_entry(git_SHA_CTX *c, int fd, struct cache_entry *ce) name = ondisk->name; memcpy(name, ce->name, ce_namelen(ce)); - return ce_write(c, fd, ondisk, size); + result = ce_write(c, fd, ondisk, size); + free(ondisk); + return result; } int write_index(struct index_state *istate, int newfd) -- 1.7.2.1.544