From: Thomas Rast <trast@student.ethz.ch>
Date: Thu, 05 Aug 2010 20:38:36 GMT
Subject: Re: [PATCH v4 11/18] Add tests for line history browser
Message-ID: <201008052238.36892.trast@student.ethz.ch>
In-Reply-To: <1281024717-7855-12-git-send-email-struggleyb.nku@gmail.com>

Bo Yang wrote:
> t4301: for simple linear history only
> t4302: for history containing merge
> 
> Signed-off-by: Bo Yang <struggleyb.nku@gmail.com>
> ---

Note that applying this with --whitespace=fix will make the tests
fail, as there are diffs contained which must preserve the SP TAB
sequence of context lines.

> +test_expect_success \
> +    'validate the output.' \
> +    'test_cmp current-path0 expected-path0 &&
> +	 test_cmp current-path1 expected-path1 &&
> +	 test_cmp current-pathall expected-pathall &&
> +	 test_cmp current-linenum expected-linenum &&
> +	 test_cmp current-always expected-always'

Please split these and move them into the tests that generate them.

I also think the style these days is

test_expect_success 'description' '
	line 1 &&
	line 2
'

but please only convert them now if you see an obvious way to do it
automatically.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch