From: Sven Verdoolaege <skimo@kotnet.org>
Date: Mon, 02 Aug 2010 12:47:29 GMT
Subject: Re: [PATCH 1/3 v4] Add a macro DIFF_QUEUE_CLEAR.
Message-ID: <20100802124729.GK12084MdfPADPa@purples>
In-Reply-To: <1273207949-18500-2-git-send-email-struggleyb.nku@gmail.com>

On Thu, May 06, 2010 at 09:52:27PM -0700, Bo Yang wrote:
> Refactor the diff_queue_struct code, this macro help
> to reset the structure.
> 
[..]
> 
> diff --git a/diff.c b/diff.c
> index e40c127..4a350e3 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -2540,6 +2540,7 @@ static void run_checkdiff(struct diff_filepair *p, struct diff_options *o)
>  void diff_setup(struct diff_options *options)
>  {
>  	memset(options, 0, sizeof(*options));
> +	memset(&diff_queued_diff, 0, sizeof(diff_queued_diff));
>  

What's this line for?  It doesn't seem to be explained by the commit
message and it breaks "git diff-files -p --submodule".
Without this line, I get the following output in one of my projects:

    Submodule barvinok contains untracked content
    Submodule barvinok contains modified content
    Submodule barvinok e129555..833e4a6:
      > iscc: use simplified CLooG interface
    Submodule cloog contains untracked content
    Submodule cloog f083938..4684a24:
      > partial doc
      > cloog_names_read_strings: do not generate names if they cannot be read
      > cloog_program_read: separate reading from input from construction of CloogProgram
    Submodule cloog-polylib contains untracked content
    Submodule cloog-polylib contains modified content
    Submodule isl contains untracked content
    Submodule isl 892fb27..5292e00:
      > isl_transitive_closure.c: anonymize input map during incremental computation
      > isl_transitive_closure.c: keep track of domains for Floyd-Warshall
      > isl_dim_drop: always remove tuple name, even if number of dims to drop is zero
      > isl_dim_set_tuple_name: allow explicit removal of tuple name
    Submodule isl-polylib contains untracked content
    Submodule isl-polylib 531cb00..e9e2edf:
      > stop using isl_basic_map internals
    Submodule polylib contains untracked content

With the line, I only get

    Submodule barvinok contains untracked content
    Submodule barvinok contains modified content
    Submodule barvinok e129555..833e4a6:
      > iscc: use simplified CLooG interface

skimo