From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 29 Jul 2010 02:48:34 GMT
Subject: Re: [PATCH 4/4 v2] Allow detached form for --glob, --branches, --tags and --remote.
Message-ID: <20100729024834.GN29156@dert.cs.uchicago.edu>
In-Reply-To: <1280310062-16793-4-git-send-email-Matthieu.Moy@imag.fr>

Matthieu Moy wrote:

> -			if (!prefixcmp(arg, "--branches=")) {
> +			if ((argcount = diff_long_opt("branches", argv + i, &optarg))) {
> +				i += argcount - 1;
>  				struct all_refs_cb cb;

As before: is this the right change where the argument is
optional?

Thanks for a pleasant read.
Jonathan