From: Jonathan Nieder <jrnieder@gmail.com>
Date: Thu, 29 Jul 2010 01:16:02 GMT
Subject: Re: [PATCH v2 3/5] t/t5800-remote-helpers.sh: Skip with prereq on python <2.4
Message-ID: <20100729011602.GG29156@dert.cs.uchicago.edu>
In-Reply-To: <1280313299-721-4-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> Change the t/t5800-remote-helpers.sh test to skip with the the
> three-arg prereq form of test_expect_success instead of bailing out.

Right:

> +++ b/t/t5800-remote-helpers.sh
> @@ -13,13 +13,11 @@ if sys.hexversion < 0x02040000:
>      sys.exit(1)
>  '
>  then
> -	:
> -else
> -	skip_all='skipping git remote-testgit tests: requires Python 2.4 or newer'
> -	test_done
> +    # Requires Python 2.4 or newer
> +	test_set_prereq PYTHON_24
>  fi

And as a bonus, this makes the test clearer.  Nice.

I would suggest dropping the "Requires Python 2.4" comment, or
maybe moving it somewhere else with a change to explain that
it is git-remote-testgit that requires Python ≥ 2.4
(rather than the remote helper facility in general).

The rest of the series looks good to me.

Thanks again,
Jonathan