From: Jeff King <peff@peff.net>
Date: Tue, 27 Jul 2010 05:46:38 GMT
Subject: Re: rfc - Changing the way gitk and git-gui are managed
Message-ID: <20100727054638.GA6662@coredump.intra.peff.net>
In-Reply-To: <AANLkTin+jUB85Zua7TP_dmdU9QSEiAuTDZhPQQ7hQTP-@mail.gmail.com>

On Tue, Jul 27, 2010 at 01:42:39AM -0400, Avery Pennarun wrote:

> On Tue, Jul 27, 2010 at 1:30 AM, Jeff King <peff@peff.net> wrote:
> > On Fri, Jul 23, 2010 at 02:16:45AM -0400, Avery Pennarun wrote:
> >> Only this: Junio said that there are no major downsides to this change
> >> - and given the slow pace of change in gitk/git-gui, this is probably
> >> true - but are there any *upsides*?  What problem does this solve?
> >
> > One minor complaint with the current setup is that browsing the history
> > with path limiting is unintuitive. You can't do "gitk gitk" in the
> > gitk-git directory. You must instead do "cd .. && gitk -- gitk".
> 
> Arguably this would be an encouragement to fix the path limiting code,
> in a similar way that people expect switching to a submodule setup to
> encourage people to fix submodules :)

Heh. Somewhat true. My multi-file --follow code actually handles "git
log --follow gitk-git", but it does look awful in gitk. And that is not
likely to be fixed soon, as --follow and things like parent rewriting
simply don't work together at this point.

-Peff