From: Jonathan Nieder Date: Sun, 25 Jul 2010 17:48:32 GMT Subject: Re: [PATCH v2 0/7] Detailed test coverage reports for Git Message-ID: <20100725174832.GB9146@burratino> In-Reply-To: Ævar Arnfjörð Bjarmason wrote: > On Sun, Jul 25, 2010 at 17:20, Jonathan Nieder wrote: >> Ævar Arnfjörð Bjarmason wrote: >>> Ævar Arnfjörð Bjarmason (7): >>>   gitignore: Ignore files generated by "make coverage" >>>   Makefile: Include subdirectories in "make cover" reports >>>   Makefile: Split out the untested functions target >>>   Makefile: Add coverage-report-cover-db target >>>   Makefile: Add coverage-report-cover-db-html target >>>   t/README: A new section about test coverage >>>   t/README: Add a note about the dangers of coverage chasing [...] > All the changes you made look good, I approve of having them squashed > when this is applied. Thanks. I hope not. :) The change to coverage-clean suggested in my reply to patch 4 needs at least a "-r" after the $(RM), since I had not noticed that cover_db is a directory.