From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 25 Jul 2010 17:17:33 GMT
Subject: Re: [PATCH v2 5/7] Makefile: Add coverage-report-cover-db-html target
Message-ID: <20100725171733.GB8604@burratino>
In-Reply-To: <1280068861-17701-6-git-send-email-avarab@gmail.com>

Ævar Arnfjörð Bjarmason wrote:

> Add a target to generate a detailed HTML report for the entire Git
> codebase using Devel::Cover's cover(1) tool. Output it in
> cover_db_html instead of the default cover_db, so that it isn't mixed
> up with our raw report files.

Oh!  Apparently these are directories. ;-)

diff --git i/.gitignore w/.gitignore
index baed247..54280af 100644
--- i/.gitignore
+++ w/.gitignore
@@ -209,4 +209,4 @@
 *.gcov
 /coverage-untested-functions
 /cover_db
-/cover_db_html
+/cover_db_html/
diff --git i/Makefile w/Makefile
index b6975aa..0fdb434 100644
--- i/Makefile
+++ w/Makefile
@@ -2282,6 +2282,7 @@ coverage:
 
 object_dirs := $(sort $(dir $(OBJECTS)))
 coverage-clean:
+	$(RM) -r cover_db_html
 	$(RM) $(addsuffix *.gcov,$(object_dirs))
 	$(RM) $(addsuffix *.gcda,$(object_dirs))
 	$(RM) $(addsuffix *.gcno,$(object_dirs))
@@ -2307,5 +2308,5 @@ coverage-untested-functions: coverage-report
 coverage-report-cover-db: coverage-report
 	gcov2perl -db cover_db *.gcov
 
-coverage-report-cover-db-html: coverage-report-cover-db
+cover_db_html: coverage-report-cover-db
 	cover -report html -outputdir cover_db_html cover_db
--