From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 25 Jul 2010 16:37:42 GMT
Subject: Re: [PATCH v2 1/7] gitignore: Ignore files generated by "make coverage"
Message-ID: <20100725163742.GA25658@burratino>
In-Reply-To: <1280068861-17701-2-git-send-email-avarab@gmail.com>

Hi,

Ævar Arnfjörð Bjarmason wrote:

> Change gitignore to ignore the *.gcda, *.gcno and *.gcov files
> generated by GCC and our coverage invocations.

Good idea.  The following is nitpicking of the worst kind; sorry.

It is easier to maintain frequently-changing lists like .gitignore
and the #include lines in source files if new additions go in some
logical place in the middle instead of the end.  There is less
lock contention that way. :)

So maybe:

diff --git i/.gitignore w/.gitignore
index 0e61845..57f79ef 100644
--- i/.gitignore
+++ w/.gitignore
@@ -181,6 +181,10 @@
 *.[aos]
 *.py[co]
 .depend/
+*.gcda
+*.gcno
+*.gcov
+/coverage-untested-functions
 *+
 /config.mak
 /autom4te.cache
@@ -204,7 +208,3 @@
 *.pdb
 /Debug/
 /Release/
-*.gcda
-*.gcno
-*.gcov
-/coverage-untested-functions
--