From: Ramkumar Ramachandra Date: Wed, 21 Jul 2010 19:03:24 GMT Subject: Re: [PATCH v2] Add svnrdump Message-ID: <20100721190324.GC23839@kytes> In-Reply-To: <20100713201105.GN13310@ted.stsp.name> Hi Stefan, Stefan Sperling writes: > Copy of what and when? This baton is global for the entire edit... > > Going through the code, I see that you're using this to indicate to > dump_node() whether an add_directory() or add_file() was in fact a copy. > Why not remove this field from the struct and add it as a parameter to > dump_node instead? This is an excellent catch! It's in the editor baton for historical reasons- cleaned up with my latest commit. Thanks :) -- Ram