From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 12 Jul 2010 16:39:35 GMT
Subject: Re: [PATCH 2/2] revert: don't print "Finished one cherry-pick." if commit failed
Message-ID: <20100712163934.GA1869@burratino>
In-Reply-To: <20100712115455.12251.47449.chriscool@tuxfamily.org>

Christian Couder wrote:

> And, while at it, refactor commit code into a new run_git_commit()
> function.

Probably should be two patches.

> +++ b/builtin/revert.c
> @@ -492,48 +518,17 @@ static int do_pick_commit(void)
>  			mebuf.buf, help_msg());
>  		rerere(allow_rerere_auto);
>  	} else {
> -		fprintf(stderr, "Finished one %s.\n", mebuf.buf);
> +		if (!no_commit)
> +			res = run_git_commit(defmsg);
> +		if (!res)
> +			fprintf(stderr, "Finished one %s.\n", mebuf.buf);
>  	}

Ack for this part.  Thanks.