From: Jakub Narebski Date: Thu, 08 Jul 2010 19:01:40 GMT Subject: Re: gitweb.perl suggestion Message-ID: <201007082101.41286.jnareb@gmail.com> In-Reply-To: <19510.3108.337932.666012@winooski.ccs.neu.edu> Eli Barzilay wrote: > On Jul 8, Jakub Narebski wrote: > > > > So your proposed solution is good enough, but perhaps better would > > be to leave 'action' unset if there is no parent info? Then > > dispatch would guess action, instead of doing it in less > > sophisticated way in evaluate_path_info(). > > Ah, looking at the dispatch point, I see what you're talking about. > But that sounds like a larger change to the code -- since it would > probably lead to more default actions that get determined in dispatch > instead of earlier. I don't remember if it was the real reson why http://gitweb/project/ defaults to 'shortlog' action, but can be commit, but can be also tag. The 'shortlog' action makes sense for both... assuming that tag points to a commit object, that is. P.S. As usual, patches welcome... -- Jakub Narebski Poland