From: Jeff King <peff@peff.net>
Date: Wed, 07 Jul 2010 17:50:37 GMT
Subject: Re: Why is "git tag --contains" so slow?
Message-ID: <20100707175037.GB4979@coredump.intra.peff.net>
In-Reply-To: <1278430303.32094.15.camel@wpalmer.simply-domain>

On Tue, Jul 06, 2010 at 04:31:43PM +0100, Will Palmer wrote:

> Clearly, marking already-traversed histories was the right thing to do,
> and if I read correctly, made a good improvement on its own. But you
> seem to have crossed a line at some point between "optimization" and
> "potentially giving the wrong answer because it's faster"

As a side-note to what I said in my other email, the sinful thing here
is not this optimization (my patch 2/4). It's _defaulting_ the
optimization to on (my patch 3/4). With just 2/4, it's something that a
user can enable to get better speed if they feel confident there is no
large skew in their repo.

-Peff