From: Jonathan Nieder <jrnieder@gmail.com>
Date: Wed, 30 Jun 2010 20:37:59 GMT
Subject: Re: [PATCH 3/8] bundle: give list_prerequisites() loop body its own function
Message-ID: <20100630203759.GD23400@burratino>
In-Reply-To: <7vmxuc5rcv.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> @@ -209,33 +236,11 @@ static int list_prerequisites(int bundle_fd, struct rev_info *revs,
>>  	if (prepare_revision_walk(&boundary_revs))
>>  		return error("revision walk setup failed");
>>  
>> -	while ((rev = get_revision(&boundary_revs))) {
>> -		if (rev->object.flags & BOUNDARY) {
>> -...
>> -		} else {
>> +	while ((rev = get_revision(revs))) {
>> +		if (rev->object.flags & BOUNDARY)
>> +			list_prerequisite(bundle_fd, revs, rev);
>> +		else
>>  			rev->object.flags |= SHOWN;
>> -		}
>
> You used to walk boundary_revs but now you walk revs that is given by the
> caller

Agh!  Typo.  Thanks for catching it.