From: Thomas Rast <trast@student.ethz.ch>
Date: Fri, 11 Jun 2010 16:34:35 GMT
Subject: Re: [PATCH next] test-lib: set $DIFF to diff if it is unset
Message-ID: <201006111834.36226.trast@student.ethz.ch>
In-Reply-To: <7vhbl9k0jv.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:
> Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil> writes:
> 
> > I think what should be done instead, is to move this section
> > down below the line where GIT-BUILD-OPTIONS is sourced.  That
> > way, the value of $DIFF can be gotten from that file.
> >
> > I guess GIT_TEST_CMP and GIT_TEST_CMP_USE_COPIED_CONTEXT
> > should be written into GIT-BUILD-OPTIONS too.
> 
> I like that.  Something like this?

Fine by me, and tested.

Acked-by: Thomas Rast <trast@student.ethz.ch>

-- 
Thomas Rast
trast@{inf,student}.ethz.ch