From: Petr Baudis <pasky@suse.cz>
Date: Mon, 07 Jun 2010 14:48:52 GMT
Subject: Re: [PATCH/RFC] gitweb: Create Gitweb::Git module
Message-ID: <20100607144852.GN20775@machine.or.cz>
In-Reply-To: <1275859451-21787-1-git-send-email-pavan.sss1991@gmail.com>

On Mon, Jun 07, 2010 at 02:54:11AM +0530, Pavan Kumar Sunkara wrote:
> @@ -39,9 +38,8 @@ BEGIN {
>  # with their descriptions is listed in Gitweb::Config.
>  $version = "++GIT_VERSION++";
>  
> -# core git executable to use
> -# this can just be "git" if your webserver has a sensible PATH
> -our $GIT = "++GIT_BINDIR++/git";
> +#only this variable has it's root in Gitweb::Git
> +$GIT = "++GIT_BINDIR++/git";
>  
>  $projectroot = "++GITWEB_PROJECTROOT++";
>  $project_maxdepth = "++GITWEB_PROJECT_MAXDEPTH++";

That comment is super-cryptic, I'd suggest either rewording it or
dropping it completely.

> @@ -1548,21 +1536,6 @@ sub get_feed_info {
>  ## ----------------------------------------------------------------------
>  ## git utility subroutines, invoking git commands

Is there any reason why didn't you move the rest of the commands from
this section to Gitweb::Git as well?

				Petr "Pasky" Baudis