From: Jonathan Nieder Date: Sun, 30 May 2010 10:09:30 GMT Subject: Re: [PATCH 5/7] Add API for string-specific memory pool Message-ID: <20100530100929.GB6242@progeny.tock> In-Reply-To: Ramkumar Ramachandra wrote: > Jonathan Nieder wrote: >> style nitpick: should use space instead of tab > > Quick doubt: Does running whitespace-cleanup (Emacs) on all the files > before generating patches suffice? No idea. Documentation/CodingStyle in linux-2.6 has some emacs tips. >> some platforms git supports still don’t have stdint.h iirc. > > Oh. What do we do about stdint.h then? Luckily, the systems without stdint.h have inttypes.h (and vice versa[1]), so git-compat-util.h takes care of it. Jonathan [1] inttypes.h is the older standard, and almost all systems support it, but Interix has stdint.h but not inttypes.h. So it goes.