From: Paul Mackerras <paulus@samba.org>
Date: Sun, 30 May 2010 02:22:31 GMT
Subject: Re: [PATCH v2] gitk: Show notes by default (like git log do)
Message-ID: <20100530022231.GF2538@brick.ozlabs.ibm.com>
In-Reply-To: <1274349041-7886-1-git-send-email-kirr@mns.spb.ru>

On Thu, May 20, 2010 at 01:50:41PM +0400, Kirill Smelkov wrote:

> Starting from ~ git-1.6.6, log, show & whatchanged show notes by default.
> 
> On the other hand, gitk does not show notes by default, because under
> the hood it calls `git log --pretty=raw ...` to get the log, and in
> `git log` notes are turned off, when user specifies format or pretty
> settings.
> 
> Yes, it is possible to invoke `gitk --show-notes` explicitly, but since
> from user's perspective, gitk is gui enabled git log, it would be
> logical for gitk to show notes by default too for consistency.
> 
> In git, --show-notes was introduced in 66b2ed (Fix "log" family not to
> be too agressive about showing notes) which predates 1.6.6.2
> 
> Notes can still be supressed with `gitk --no-notes`.
> 
> Cc: Michael J Gruber <git@drmicha.warpmail.net>
> Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru>

Thanks, applied.

Paul.