From: Jeff King Date: Tue, 25 May 2010 09:33:37 GMT Subject: Re: [PATCH 0/6 rebase-version] Make git log --graph looks better with -p and other diff options Message-ID: <20100525093337.GB32460@coredump.intra.peff.net> In-Reply-To: On Tue, May 25, 2010 at 05:31:23PM +0800, Bo Yang wrote: > > I have to admit I don't quite understand from the commit message what > > the problem is that this is fixing. > > Ah, the previous code just call a emit_line for parts of the line, and > this commit change this behavior. It firstly compose the different > parts into one line and only call a emit_line. This is necessary > because each time we call emit_line, there will be a graph prefix > output. :) OK. I understood what it _does_ from the commit message and seeing the code, but the missing bit was that calling emit_line would get multiple graph prefixes. Thanks. -Peff