From: Christian Couder <chriscool@tuxfamily.org>
Date: Mon, 24 May 2010 20:05:43 GMT
Subject: Re: [PATCHv5 GSoC] gitweb: Move static files into seperate subdirectory
Message-ID: <201005242205.43194.chriscool@tuxfamily.org>
In-Reply-To: <1274714564-7553-1-git-send-email-pavan.sss1991@gmail.com>

On Monday 24 May 2010 17:22:44 Pavan Kumar Sunkara wrote:
> 
>  gitweb/{ => static}/git-favicon.png |  Bin 115 -> 115 bytes
>  gitweb/{ => static}/git-logo.png    |  Bin 207 -> 207 bytes
>  gitweb/{ => static}/gitweb.css      |    0
>  gitweb/{ => static}/gitweb.js       |    0

The patch is supposed to move git-favicon.png and git-logo.png into 
gitweb/static but it doesn't.

>  diff --git a/gitweb/gitweb.css b/gitweb/static/gitweb.css
> similarity index 100%
> rename from gitweb/gitweb.css
> rename to gitweb/static/gitweb.css
> diff --git a/gitweb/gitweb.js b/gitweb/static/gitweb.js
> similarity index 100%
> rename from gitweb/gitweb.js
> rename to gitweb/static/gitweb.js

Only gitweb.css and gitweb.js are moved into gitweb/static and that gives some 
errors when running make install:

install -d -m 755 '/home/christian/share/gitweb'
install -m 755 gitweb.cgi '/home/christian/share/gitweb'
install -d -m 755 '/home/christian/share/gitweb/static'
install -m 644 static/gitweb.js static/gitweb.css static/git-logo.png 
static/git-favicon.png '/home/christian/share/gitweb/static'
install: cannot stat `static/git-logo.png': No such file or directory
install: cannot stat `static/git-favicon.png': No such file or directory
make[1]: *** [install] Error 1
make[1]: Leaving directory `/home/christian/work/git/gitweb'
make: *** [install] Error 2

Best regards,
Christian.