From: Bill Pemberton <wfp5p@viridian.itc.virginia.edu>
Date: Mon, 03 May 2010 12:46:10 GMT
Subject: Re: [PATCH] blame: add a range option to -L
Message-ID: <20100503124610.DB96C41205@viridian.itc.virginia.edu>
In-Reply-To: <20100502091433.GA1854@progeny.tock>

> > In addition to + and - you can now use r to specify how many lines
> > around <start> that you want to see.  For example: -L 20,r5 would show
> > lines 15 through 25
> 
> >From too much exposure to subversion, the r suggests “revision”.
> But ± is too hard to type, so I guess r will have to do.
> 

I wasn't too thrilled with using r either, but I couldn't think of
anything better.


> > +		/* if top is negative then top is actually a range
> > +		   that was specified with the r option */
> > +		if (*top < 1) {
> > +		    long x = *top;
> > +		    *top = *bottom - x;
> > +		    *bottom += x;
> > +		    if (*bottom < 1)
> > +			*bottom = 1;
> > +		}
> 
> How does this treat -L 5,-10?
> 

Yes, you're correct, my code will mess that up.  I thought I had
verified that parse_loc() would never return a number less than 1 as
*top, but looking again I see I didn't do that.  So my patch is no
good.  Sorry folks.

-- 
Bill Pemberton                                 wfp5p@virginia.edu
ITC/Unix Systems                               flash@virginia.edu
University of Virginia